On Mon, 31 Aug 2020 at 19:58, Scott Kostyshak <[email protected]> wrote:
> On Mon, Aug 31, 2020 at 07:06:20PM +0200, Kornel Benko wrote: > > Am Mon, 31 Aug 2020 18:54:29 +0200 > > schrieb Kornel Benko <[email protected]>: > > > > > Am Mon, 31 Aug 2020 18:41:35 +0200 > > > schrieb Kornel Benko <[email protected]>: > > > > > > > So, there is something fishy ... and 'git log' did not change. > > > > Unfortunately I am no a git-expert, so no idea how to cure this > stage. > > > > > > > > Kornel > > > > > > OK, found it. Wrong branch. > > > features/docbook -> feature/docbook > > > > > > Compiling now. > > > > > > Kornel > > > > Compilation errors start with attached. > > Thibaut, I'm not sure what compiler you're using, but is there an analog > of "-Werror" (used on GCC and Clang) for it that you can enable? I > compile with it and compilation on your branch stopped because of an > error (converted from a warning) of something like "unused argument". > > A lot of warnings are harmless, but we make a big effort even on master > to keep warnings clean and not introduce new code that triggers > warnings. That way when there is a warning that actually ends up being a > non-trivial problem, it is easy to spot it immediately. Also, it makes > it easier to review proposed code changes when there are no warnings. > It's already enabled through CMake, I suppose, as I sometimes have compilation halted due to a variable being unused. I try to reduce the amount of warnings in the code I write and in the surroundings already :). The major annoyance is that different compilers will yell at different things… and their flags do not always enable the same warnings. As it's quite complicated to get all the dependencies for a given compiler, it would literally take me hours to get another compiler working with LyX… It would probably be easier to have a Linux virtual machine just to test for warnings.
-- lyx-devel mailing list [email protected] http://lists.lyx.org/mailman/listinfo/lyx-devel
