On Mon, Aug 31, 2020 at 04:24:59PM -0400, Scott Kostyshak wrote: > > I understand the general reasoning but > > a) I find it unfair to force Thibaout to figure out tests on windows, so > > his stuff gets merged. The more that I expect bunch of weird issues > > popping up while trying to do so. While having tests working in > > windows would be nice, if its not low hanging fruit I would like > > his free time to be primarily spent on docbook instead of figuring > > out perl configuration delicacies. > > I agree that should not be required. I offered to run the tests on the > branch.
Good, thanks :) > > b) docbook export is completely new and we are not really breaking old > > legacy. My suggestion is that if failling docbook tests disturb you, > > simply disable all of them and start enabling them and slowly one > > by one. It seems to me that having other people to test the code on > > various architectures and even release some technical versions of 2.4 > > so people can give feedback to the actual output overweigths the tests > > issues. > > > > (I might be wrong on this if you suggest that his code breaks non > > dobook tests...) > > On current master, open de/UserGuide.lyx and go to File > Export > LyXHTML. > > I think that for some of the DocBook features it is unavoidable to not > touch other parts of the code. In some sense, I think that's a great > thing since from the little I understand, he is fixing and generalizing > core LyX code as well. His progress is quite impressive. I spent several hours of testing that xHTML export of User Guide after docbook rewrite produces equivalent xHTML output after the first wave of patches (it was not matter of trivial diff because some things changed.) So yes, the chances is there and our simple tests wouldn't help. If I see similar changes in the code I can check again, but I still think that having the codebase for others in master is at the moment more valuable than clean docbook tests, which might not be even correct from the perspective of the second rewrite. Pavel -- lyx-devel mailing list [email protected] http://lists.lyx.org/mailman/listinfo/lyx-devel
