On 11/11/20 12:18 PM, Jean-Marc Lasgouttes wrote:
Le 11/11/2020 à 17:13, Richard Kimberly Heck a écrit :
commit fdd0a6f84923f1d4a1f82457a3e256a2ee706f6b
Author: Richard Kimberly Heck <rikih...@lyx.org>
Date: Wed Nov 11 11:24:59 2020 -0500
Revert "Improve structure of updateMacros"
The problem here is that the check against TEXT_CODE only
catches InsetText, and not its subclasses. Same for the check
against MATH_HULL_CODE. So there is reason not to check codes
here.
I really think that we should reduce our use of codes as much as
possible. Isn't it possible to use a virtual method here that would be
implemented by each inset? t is bad to have the knowledge about the
insets scattered around the code.
The existing code uses some virtual methods. There are probably other
places we could do that.
What else do you have in mind?
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
