On Mon, Mar 15, 2021 at 05:33:49PM +0100, Enrico Forestieri wrote:
> commit 635a7d77ddc94c63d52494dc4d68a930faccf45f
> Author: Enrico Forestieri <for...@lyx.org>
> Date:   Mon Mar 15 17:09:09 2021 +0100
> 
>     Allow compiling with Qt6
>     
>     This commit allows compiling LyX with Qt6 when using autotools.
>     For a successful compilation the following 2 conditions must be met.
>     
>     1) The Qt6 qmake has to come first in PATH, so that the command
>        "qmake -v | grep -o 'Qt version .'" returns "Qt version 6".
>     2) The --enable-qt6 switch has to be passed to the configure command.
>     
>     If --enable-qt6 is used but Qt6 is not found, Qt5 is tried as a fallback.
>     If also Qt5 is not found, configuring for Qt4 is attempted.
>     If --enable-qt6 is not used, then things go as usual. This means that Qt5
>     is tried first and then Qt4, unless --disable-qt5 is used, in which case
>     Qt4 is directly attempted. This means that existing scripts should
>     continue working unmodified.
>     
>     LyX should compile with Qt6 on windows and linux, and possibly also on
>     mac, but I could not test that. However, it is not guaranteed that it
>     works as it should. In particular I am not sure that I got right the
>     conversion from QRegExp to QRegularExpression. For sure, the syntax
>     highlighting seems to not work right. Someone in the know should take
>     a look at that. I am able to load documents and compile them but some
>     thourough testing is needed. However, when compiling for Qt5 or Qt4,
>     I tried to make sure that the functionality is preserved.
> ---

Are there still QRegExp that need to be changed? I got an error from
src/support/qstring_helpers.cpp.

Also, why use

  #include <QtCore5Compat/QRegExp>

in CategorizedCombo.cpp, but not other places?

Scott

Attachment: signature.asc
Description: PGP signature

-- 
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel

Reply via email to