On 07-May-2001 Lars Gullik Bjønnes wrote:

> (this patch started with the TextContainer... then NO_NEXT was added
> ... eventually removal of LyXParagraph::Clone... if I can't find out
> what is happening I will begin to feed it to cvs is small (non-buggy)
> batches.)

Well Lars I had a fast look and it seems to me the assignment of the
inset in the TextContainer is strange (did you think of the Undo handling?).
Then you just do too much in one step. Why not just first do all the changes
you did in changing string to osstream and then get the textcontainer so
it would be really easier to see what you're really doing.

One more thing I saw. You added #includes to .h files without changing
anything in that .h file. It seems strange to me and we should try to
minimize including files in .h files, don't you think so?

         Jürgen (who really should find the time to work on the tabular again!)

--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen Vigna        E-Mail:  [EMAIL PROTECTED]
Italienallee 13/N       Tel/Fax: +39-0471-450260 / +39-0471-450253
I-39100 Bozen           Web:     http://www.sad.it/~jug
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._

transfer, n.:
        A promotion you receive on the condition that you leave town.

Reply via email to