On Thu, Feb 27, 2025 at 01:41:09PM +0900, Koji Yokota wrote: > > E.g. Color on button of margin inset is totally unreadable, > > I corrected this in the attached file. I hope this looks good now. (I found > choosing color is difficult. Human perception of color doesn???t look linear!)
Good, thanks, I'll recheck later once you commit the testing file. We will probably find some old bugs as the one below... > > text inside Greyedout inset is not well readable, > > This looks like a problem. Actually, dark color for ???greyedout inset > text??? is specified to a different color (grey) but shown as thick blue. > Also, color for collapsible inset label, say ???Box (double frame)???, > doesn???t look to reflect specification in the color preference dialog. > > Some investigation is needed here. I think these problems existed for a while. Feel free to create bugs for each of these problems, at least we found them through this overhaul. > This reflects a taste in the original theme in wiki, which sets different > color between collapsible and non-collapsible insets. I see, ok then. > > Also I see on the console the following message after little playing themes: > > Color.cpp (544): ColorSet::getFromLyXName: Unknown color > > "notefontcolor@/home/lyx/newfile1.lyx" > > > > Is this something to be expected? > > Since the color ???notefontcolor??? is not included in ColorCode.h, it will > not be handled in changing color theme. Is this color newly introduced? > (Maybe Juergen knows it?) As Juergen pointed out, this might not have anything to do with your patch. I'll try to come up with some recipy later. Last but not least, please look at the [automated testing] emails in the list. It's testing for very old and very new gcc compilers/Qt's, some Qt ifdefs are probably needed for your feature to work on these setups Pavel -- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
