On Sat, Jun 07, 2025 at 11:40:05AM +0200, Pavel Sanda wrote:
> On Fri, Jun 06, 2025 at 11:32:53PM +0000, Scott Kostyshak wrote:
> > commit 64789ba422bdec692288f9c2e48299d6708b3741
> > Author: Scott Kostyshak <skost...@lyx.org>
> > Date: Sat Jun 7 01:22:55 2025 +0200
> >
> > Fix incorrect escape in a QString
> >
> > This fixes the following warning from Clang:
> >
> > src/frontends/qt/GuiView.cpp:733:56: warning: use of non-standard
> > escape character '\%' [-Wpedantic]
> > 733 |
> > zoom_value_->setMinimumWidth(fm.horizontalAdvance("444\%"));
> > | ^~
> > ---
> > src/frontends/qt/GuiView.cpp | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
> > index b05f19b591..5f48309416 100644
> > --- a/src/frontends/qt/GuiView.cpp
> > +++ b/src/frontends/qt/GuiView.cpp
> > @@ -730,9 +730,9 @@ GuiView::GuiView(int id)
> > zoom_value_->setForegroundRole(statusBar()->foregroundRole());
> > zoom_value_->setFixedHeight(fm.height());
> > #if (QT_VERSION >= QT_VERSION_CHECK(5, 11, 0))
> > - zoom_value_->setMinimumWidth(fm.horizontalAdvance("444\%"));
> > + zoom_value_->setMinimumWidth(fm.horizontalAdvance("444%"));
> > #else
> > - zoom_value_->setMinimumWidth(fm.width("444\%"));
> > + zoom_value_->setMinimumWidth(fm.width("444%"));
> > #endif
> > zoom_value_->setAlignment(Qt::AlignCenter);
> > zoom_value_->setText(toqstr(bformat(_("[[ZOOM]]%1$d%"), zoom)));
>
> If you look into commit history and associated bug you will see that change
> to 444\%
> including escape was intentional.Thanks, Pavel. I've restored it at a9bc0ac2. Scott
signature.asc
Description: PGP signature
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
