Re: [LyX/master] Return const references when it makes sense

[Richard Kimberly Heck]

On 6/22/25 2:01 PM, Jean-Marc Lasgouttes wrote:

--- a/src/Floating.h
+++ b/src/Floating.h
@@ -42,7 +42,7 @@ public:
        ///
        std::string const & floattype() const { return floattype_; }
        ///
-       std::string docbookFloatType() const;
+       std::string docbookFloatType() const { return docbook_float_type_; }
        ///
        std::string const & placement() const { return placement_; }
        ///
@@ -83,7 +83,8 @@ public:
        ///
        std::string docbookTag(bool hasTitle = false) const;
        ///
-       std::string docbookAttr() const;
+       std::string docbookAttr() const { return docbook_attr_; }
+

Can those not be const refs?

diff --git a/src/frontends/qt/CustomizedWidgets.h 
b/src/frontends/qt/CustomizedWidgets.h
index ca68ca99cf..223913650a 100644
--- a/src/frontends/qt/CustomizedWidgets.h
+++ b/src/frontends/qt/CustomizedWidgets.h
@@ -31,8 +31,8 @@ class ShortcutWidget : public QLabel {
  public:
        ShortcutWidget(QWidget * parent);
        void reset();
-       KeySequence const getKeySequence() const;
-       void setKeySequence(lyx::KeySequence const & s);
+       KeySequence const getKeySequence() const { return keysequence_; }

This one, too?

diff --git a/src/insets/InsetSpace.h b/src/insets/InsetSpace.h
index 719e09483d..7cb3b3ab49 100644
--- a/src/insets/InsetSpace.h
+++ b/src/insets/InsetSpace.h
@@ -103,15 +103,13 @@ public:
        ///
        InsetSpaceParams const & params() const { return params_; }
        ///
-       InsetSpaceParams::Kind kind() const;
-
+       InsetSpaceParams::Kind kind() const { return params_.kind; }
        ///
        static void string2params(std::string const &, InsetSpaceParams &);
        ///
        static std::string params2string(InsetSpaceParams const &);
        ///
-       GlueLength length() const;
-
+       GlueLength length() const { return params_.length; }

These ones, too?

Riki


--
lyx-devel mailing list
lyx-devel@lists.lyx.org
https://lists.lyx.org/mailman/listinfo/lyx-devel