Am Tue, 15 Jul 2025 23:47:15 +0900 schrieb Koji Yokota <yoko...@gmail.com>:
> > 2025/07/15 17:35、Scott Kostyshak <skost...@lyx.org>のメール:
> > On Tue, Jul 15, 2025 at 08:43:46AM +0200, Kornel Benko wrote:
> >> Am Mon, 14 Jul 2025 16:11:47 +0200
> >> schrieb Scott Kostyshak <skost...@lyx.org>:
> >>> On Mon, Jul 14, 2025 at 03:51:03PM +0200, Jean-Marc Lasgouttes wrote:
> >>>> Looks good to me. What is not good is when you overload a method in a
> >>>> derived class. In this case, you should reimplement the original
> >>>> function in
> >>>> the new class too (or just use "using oldclass::mymethod(arg1, arg2)" or
> >>>> something like that).
>
> I see now. Thank you!
>
> >>>> My original idea was to declare it only for InsetMathChar, not Inset.
>
> I reflected it in a new fix on commit 57a24fb.
>
> >> Works here too. At least for draw(). But not for
> >> src/insets/InsetSpecialChar.cpp
> >
> > Yes, I see that too. The Pinter.h:154 is the only other warning for this
> > category besides the one Koji's patch fixes.
>
> I gave a similar treatment as given to draw() to text() functions as well in
> the above
> commit.
>
> I hope it solves the problem.
>
> Koji
It does not help, unfortunately.
...
In file included from /usr2/src/lyx/lyx-test/src/frontends/NullPainter.h:17,
from /usr2/src/lyx/lyx-test/src/insets/InsetSpecialChar.cpp:27:
/usr2/src/lyx/lyx-test/src/frontends/Painter.h:164:22: error: ‘virtual void
lyx::frontend::Painter::textWithInputMethod(int, int, lyx::char_type, const
lyx::frontend::InputMethod*, lyx::pos_type, Direction)’ was hidden
[-Werror=overloaded-virtual=]
164 | virtual void textWithInputMethod(int, int, char_type,
InputMethod const *,
| ^~~~~~~~~~~~~~~~~~~
/usr2/src/lyx/lyx-test/src/frontends/NullPainter.h:81:14: note: by ‘virtual
void
lyx::frontend::NullPainter::textWithInputMethod(int, int, const
lyx::docstring&, const
lyx::frontend::InputMethod*, lyx::pos_type, lyx::frontend::Painter::Direction)’
81 | void textWithInputMethod(int, int, docstring const &, InputMethod const
*,
| ^~~~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors
Kornel
pgpI8ojAYaSdl.pgp
Description: Digitale Signatur von OpenPGP
-- lyx-devel mailing list lyx-devel@lists.lyx.org https://lists.lyx.org/mailman/listinfo/lyx-devel
