On Wed, 22 Oct 2025 at 17:31, Jean-Marc Lasgouttes <[email protected]> wrote:
> Le 22/10/2025 à 17:02, Thibaut Cuvelier a écrit : > > I went ahead and fixed many more such issues. Here is the list of > > remaining ones, either at the intersection of an external library (and > > I'm not sure what to do) or looking more like bugs (converting doubles > > to ints): > > > > [593/614] Building CXX object src\CMakeFiles\LyX.dir\TextMetrics.cpp.obj > > D:\LyX\lyx\src\TextMetrics.cpp(1610): warning C4244: '+=': conversion > > from 'double' to 'int', possible loss of data > > D:\LyX\lyx\src\TextMetrics.cpp(1637): warning C4244: 'return': > > conversion from 'double' to 'int', possible loss of data > > The line numbers being different with my latest patch, could you provide > new ones, please. Rounding of double to int is expected since we use > ints for all painting actions, and there are some floats which are due > to justification handling mostly. > > I do not think these are real bugs. Expected, but no one is instructing the compiler that it is. (And I bet other static analysis tools dislike it.) I've just pushed a commit that adds explicit casts in these places.
-- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
