Am Wed, 29 Oct 2025 20:48:24 +0100 schrieb Georg Baum <[email protected]>:
> Am 29.10.25 um 19:09 schrieb Georg Baum: > > > > What is the purpose of handle_warning_options? If the goal is to ignore > > all warnings from thirdparty-code then we should use the SYSTEM keyword > > for those include directories (see https://cmake.org/cmake/help/latest/ > > command/ > > target_include_directories.html#command:target_include_directories or > > https://cmake.org/cmake/help/latest/command/include_directories.html) > > rather than compiler-specific ignore lists IMHO. This works also with > > MSVC, not just gcc or clang (at least since a few years: https:// > > gitlab.kitware.com/cmake/cmake/-/issues/17904) > > This would look like the attached. I also used the more specific > target_* commands (to slightly modernize the CMake code). The new syntax > is already supported by CMake 3.10, so no need to bump > cmake_minimum_required. > > Opinions? > > > Georg Looks good. But now errors in creating zlib: cc1plus: error: /usr2/src/lyx/lyx-test/3rdparty/zlib/SYSTEM: No such file or directory [-Werror=missing-include-dirs] ... We have: target_include_directories(zlibstatic PUBLIC SYSTEM ${CMAKE_CURRENT_BINARY_DIR} Maybe SYSTEM is not handled after PUBLIC in target_include_directories()? Removing 'SYSTEM' cures the compilation. Also using SYSTEM _before_ PUBLIC seems to work. Kornel Kornel
pgpYOERPouLhx.pgp
Description: Digitale Signatur von OpenPGP
-- lyx-devel mailing list [email protected] https://lists.lyx.org/mailman/listinfo/lyx-devel
