On Sun, Jun 10, 2001 at 10:31:00AM -0400, Justin R. Smith wrote:
> These patches do the following:
first as John pointed out you really should have compressed the patch !
Some people like Andre /really/ don't like things like this in their mailbox :)
Secondly, in terms of someone reviewing your patch, I suggest
1) use diff -u format. It's far more readable.
2) split the patches up. you have three separate changes. try separating these
into separate patches, and provide ChangeLogs
3) lyx-1.1.6 is only for bugfixes. new features should be done against current CVS
(see the lyx cvs page)
I can't comment on the actual patches themselves, but if you do as above you are
much more likely to get review from those who can.
regards,
john
