>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
Angus> Please review and apply. Angus
Small comments:
+ * kbmap.h (modifier_pair):
+ * paragraph.h (InsetTable, InsetList):
+ type definition made public.
What happens for InsetList/Inset table if you define inset_iterator as
friend class inset_operator {...
I am not even sure this is good c++. Just wondering.
+ * lyxfont.C (operator==, operator!=): strange error message about
+ LyXFont::FontBits being private. Yes? and? Redefining the parameter as
+ FontBits cures it. Go figure!
I thought such operators should be declared outside of classes, like
bool operator==(LyXFont::FontBits const & fb1, LyXFont::FontBits const & fb2) const
I am sure Lars knows better than I do on this case.
+
+ * tabular_funcs.C: lstrings.h must come before tabular_funcs.h or
+ the compiler is is unable to find tostr in write_attribute.
+
Why isn't lstrings.h included in tabular_funcs.h? I really think it
should, since tostr is used in there.
JMarc
