On Mon, Jul 15, 2002 at 05:57:01PM +0100, Angus Leeming wrote:
> > OK, next try... attached.
> >
> > 2002-07-15 <[EMAIL PROTECTED]>
> >
> > * counters.[Ch]: Fleshed out in preparation for taking over
> > counters functionality from text2. Compiles, untested.
> >
> > Martin
>
> This should work, allowing whatever is connected to the onstep signal to be
> informed. Assuming you expect something to be connected (I see that you've
> removed the signal from the header file).
>
> @@ -48,7 +48,7 @@ int Counter::value() const
> void Counter::step()
> {
> ++value_;
> - onstep.emit();
> + onstep();
No, commented out. I removed signal/slot completely as I didn't
understand/get working/see the need for it. But I have no strong views.
> }
>
> Do you really need to make char Counters::hebrewCounter(int n) a class
> method? It doesn't use any class variables.
>
> I'd suggest, in the .C file only:
>
> namespace {
>
> char Counters::hebrewCounter(int n)
> {
> ...
> }
>
> } // namespace anon
>
> Ditto for other, similar helper functions. Keep the header file minimal.
>
> Angus
Thanks! Learning all the time.
Hmmm... I'll think about that tomorrow at the summer cottage :-)
Sun, sea, chopping firewood...
Martin
msg41014/pgp00000.pgp
Description: PGP signature
