>>>>> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes:
Dekel> On Sun, Oct 20, 2002 at 05:38:01PM +0200, Olexij Tkatchenko
Dekel> wrote:
>> there seems to be a problem with ukrainian keyboard (koi8-u.kmap).
>> Lyx 1.2.1 is crushing on pressing any key with koi8-u.kmap
>> selected. Quoting the last symbol <,> seems to cure this. The patch
>> is attached.
Dekel> I can verify this bug, and the fix. Should I apply this patch,
Dekel> or should the crash be investigated ?
This patch makes sense, since , is a separator for lyxlex (yes I know
this is lame). Therefore, I think that this is equivalent to an empty
kmap. I agree that the code should be more robust to bad syntax (it
appears to try to do so in Trans::Load, but it seems that the code in
Intl::SetPrimary is broken. I would think that something like
void Intl::KeyMapPrim()
{
if (!trans.SetPrimary(prim_lang)) {
trans.EnablePrimary();
keymapon = true;
keymap = PRIMARY;
}
}
would be better. But this code is sooo ugly...
Dekel, I think you should apply the patch to both 1.3.0cvs and
1.2.2cvs.
JMarc
