On Friday 13 December 2002 2:44 pm, Lars Gullik Bjønnes wrote:
> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes:
> >>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
> |
> | Angus> Having said that, did we come to a consensual view on what
> | Angus> version of xforms to support in LyX 1.3? I'd prefer to throw
> | Angus> out both 0.88 and 0.89. The former because it's really old and
> | Angus> doesn't have image support. The latter because there is no
> | Angus> clean separation between 0.88 and 0.89. The functionality comes
> | Angus> with 0.89.5. It seems ridiculous to have to justifying that to
> | Angus> a user of 0.89.2 for which no other 0.89 binary was released.
> |
> | I think we should support xforms 0.89.6 and 1.0. And maybe 0.89.5 if
> | it costs nothing. Older 0.89.x are indeed out of question.
>
> This solution is also what I will be most comfortable with, even if it
> is not really what I would like to do.
>
> Let's decide upon this.
>
> (what are the differences between 0.89.5 and 0.89.6?)

None as far as the LyX sources are concerned. Probably a bug-fix release.

I have removed all of the #if blocks for xforms < 0.89.5. I have removed the 
XFORMS_IMAGE clocks from Makefile.am in both the graphics and xforms dirs.

I have not touched the configure stuff because I got a little confused. I 
think that LYX_XFORMS_IMAGE_LOADER is still needed, if only to test for 
flimage_enable_jpeg. It probably needs renaming therefore. Can someone else 
do that?

In config.h this can go:
#define USE_XFORMS_IMAGE_LOADER 1

configure checks:
...
checking for jpeg_read_header in -ljpeg... (cached) yes
checking for library containing flimage_dup... (cached) -lflimage

This can go (because we have disabled xforms ps loader):
checking for flimage_enable_ps... (cached) yes

I guess that this is dependent on the -ljpeg test above so should stay.
checking for flimage_enable_jpeg... (cached) yes

-- 
Angus

Reply via email to