On Wed, Jun 04, 2003 at 08:49:55AM +0000, Angus Leeming wrote: > Andre Poenitz wrote: > > > On Tue, Jun 03, 2003 at 06:17:10PM +0000, Angus Leeming wrote: > >> This cleans up InsetGraphics::Cache and renames it as GraphicsInset so > >> that the external inset can use it too. > > > > What do you need old_ascent_ for? > > > > + old_ascent_ = (type == IMAGE) ? loader_.image()->getHeight() : 50; > > + > > + dim.asc = old_ascent_; > > + dim.des = 0; > > + [...] > > + dim_ = dim; > > > > You could use dim_.asc instead... > > This is what I call "Juergen magic". I didn't really understand it then. I > still don't. If you tell me that it is "premature optimization" then I will > remove it.
No, I tell you that we nowadays cache all parts of the metrics in dim_, so there is no need to cache the ascent twice (once in dim_, and once in old_ascent_). Partially my doing, in fact... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
