On Mon, Jul 07, 2003 at 11:58:45PM +0800, Huang Ying wrote: > The patch contains the the main form, ie the LyXView and Aboutlyx > dialog. Just a begining with gtk frontend. The render system is based on > xft including the math things. So making sure that you have configure > the math xft font properly. I think I have seen something about that in > this mailing list.
Hi. Your patch looks pretty good from a first scan over it. Some quick comments : o 2 blank lines between functions in .C files please (I guess you can script this change) o you have too many inline functions. Please make them out of line o a couple of points had functions beginning with a capital letter. Please make them like "myFunctionBlah" instead o Why are we using Xft directly ? Doesn't gtk+ abstract the actual font loader away ? Finally, I guess I'm OK with splitting from the Gnome frontend, but we should probably decide what to do with it eventually ... just let it rot perhaps. Are you planning to implement the rest of the gtk+ port ? It's a pretty big job (mainly all the dialog code though). Do you have anybody else interested in it ? regards john
