On Wed, Jul 30, 2003 at 07:07:04PM +0100, John Levon wrote: > > Andre, what are your plans from this point ? I think we need something > like : > > o add remainingwidth as discussed
*nod* > o move the actual rowBreakPoint code to be called only from metrics. > Utilise this to call inset metrics() with correct values to fix the > "insets wider than their container" bugs *nod* > o change all code (appendPar etc.) that calls rowBreakPoint to call > metrics() on the outmost lyxtext instead I am not too sure here. I think appendPar etc should just get the structure right and not care too much for metrics related problems. > Does this plan make sense ? What are yours ? In any case, I guess first we should have a 'Paragraph::rebreakParagraph' which updates the part of the row cache that's related to this paragraph and possibly (but I am not sure here) the 'absolute y coordinates' of all the following pars, too. Next we'd split the 'structure changing' functions like appendParagraph into a structure part (sort of trivial given the std::list nature of the parlist) and a call to rebreakParagraphs for the affected paragraph. Last step would be to figure out how to call rebreakParagraph from metrics only... Concerning the textwidth issues: I tried last night again to use a value cahced from 'metrics' only (instead of all this 'workWitdh' call), and at least it does not crash. It misses, however all the funny bits about insets that want a row of there own etc, but generally I have the impression there is light at the horizon... Andre' -- Those who desire to give up Freedom in order to gain Security, will not have, nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)