Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj�nnes wrote:
>
>> This patch is too bid, too full of errors to go in, but shows a bit
>> the direction I am going in. I am going to do this is smaller steps,
>> and the result will hopefulle be a bit better than this...
>
| I _think_ I like it, but it's too big to take in in one go.
c>
| However, I think that I'd prefer
| return DispatchResult(false);
| rather than
| return DispatchResult();
yeah, I thought about this also.
The worst error in this patch is the fact that FINISHED is somethimes
used as DISPATCHED|FINISHED_XXX and other times as
UNDISPATCHED|FINISHED_XXX. You have to check where and how functions
are called to figure out which variant. I have made it bee
DISPATCHED|FINISHED_XXX all over.
Also DISPATCHED should transform to DispatchResult(true,
DispatchResult::UPDATE), and not just DisaptchResult(true) as I have
done.
| Also call the Cursor member function statusSet rather than statSet.
Or something completely different :-)
I'll continue with the small step approach...
--
Lgb
