Angus Leeming wrote:

>> hasParagraphs is never used in the code, and we need numParagraphs
>> for having PosIterator/Cursor::operator--
> 
> Who could possibly object? Go for it.

The ways of objections are misterious... ;-) I'll do it then.

>> PS: should I drop PosIterator and try to make Cursor::operator++/--
>> operative?
> 
> Why not make PosIterator fully functional and then think about

I'm doing this already: I think PosIterator in the patch I sent yesterday is
fully functional (the patch has some bugs in putting the selection at the
end of a successful search but that's another story).

[Btw, it should be super easy to implement regex searches right? It would
suffice to implement operator* that gives pit->getChar(pos) if pos < size
and some '\n' if pos == size. In that way one could also search for
newlines etc. Methink.]

> implementing Cursor in terms of PosIterator?

My concern is that Andrà has already started implementing Cursor in his own
way, and maybe his way is better. [In any case, they are very similar I
think]. But I don't want to interfere with anybody's plans.
If I could only get Andrà to comment what are his future plans on this...

Alfredo


Reply via email to