Lars Gullik Bj�nnes wrote:

> | This is aimed at fixing memory leaks in the case of exceptions...
> | (probably not all good, neither does it fix all problems...)
> 
> Updated patch.

Shouldn't you change the signature of functions like this and 
factory.C's createInset, rather than invoke auto_ptr::release?

Buffer * BufferList::newBuffer(string const & s, bool ronly)

I'd suggest that use of release is exactly contrary to your aims.


Spelling!
Index: src/trans_mgr.C
+// For the sace of boost::scoped_ptr.

Other than that, it looks Ok.

-- 
Angus

Reply via email to