Andre Poenitz wrote: > We simply should draw full paragraphs. This way we could have a smooth > drawing of 'really tall rows' and this would make the usage of > RowPainter a bit simpler, too.
Fine. > InsetText::draw > LyXText::draw (to be implemented) > Paragraph::draw (to be implemented) > RowPainter > > Nice little hierarchy. If it turns out that we waste too many cycles > that way (which I don't expect) we could always go back to That was my first patch... and fall back to this, dunno why. I'll take the ckeck out of the per-row loop in rowpainter::paintText. ;-) >> Patch to checkInsetHit to check only inside on-screen rows (i.e. >> reproduce the check in rowpainter) attached. >> >> Comments? > > Too complicated for my taste i.e. premature optimization. Better try to > solve the problem robust and 'structured' rather than adding 'ifs' and > 'thens' ;-) Ok. >> + int const first_y = bv()->top_y() - y0_; > > [Btw did I mention one of the reasons to have separate x/y cache > variables to mimic the behaviour of insets/* and mathed/*? > They are called xo_ and yo_ (from 'x _o_rigin' IIRC) there...] Oops... I should stop development with my old Remington typewriter... ;-) I'll do the change.
