On Fri, Nov 21, 2003 at 02:45:35PM +0100, Michael Schmitt wrote:
> Hi Angus,
>
> you fixed a couple of compiler warnings ("unused parameters") by simply
> removing the names of corresponding function parameters.
>
> However, I think we can completely remove the parameters as they are
> never used (in all functions with the same name).
Well spotted.
> I prepared a small patch for "getCursorPos" and "getCursorDim". Could
> you (or Andre, or Alfredo...) please check whether this is the right way
> to go or whether we will need the buffer view parameters in the future?
As it stands the cursor will get a BufferView * argument on construction
and keep this all the time as member. So the patch should be safe.
> There is a similar "problem" with methods "open" and "close" in the
> insets directory. IMHO the status of a collapsable inset (open/closed)
> should be independent from a particular buffer.
Indeed.
> If we allow an inset to be closed in one view and open in another one,
> we will certainly get into serious trouble. The only problem with
> the removal of the bufferview parameter is in "InsetERT::status". What
> should the final "if" statement look like?
The update() is unneeded nowadays, and the bv->buffer()->markDirty();
should be handled by the LFUN handler calling status. Probably
LFUN_INSET_TOGGLE in text3.C and/or lyxfunc.C.
So in the end this 'if' clause is empty and can be removed.
Andre'
