Re: [patch] support jurabib

[Angus Leeming]

Juergen Spitzmueller wrote:

Jürgen, this looks very good! A few minor questions only.
Angus


The formatting here has gone to pot:
+string const BufferParams::babelCall(string const & lang_opts) const
+{
+       string tmp = lyxrc.language_package;
+               if (!lyxrc.language_global_options
+                   && tmp == "\\usepackage{babel}")
+                       tmp = string("\\usepackage[") +
+                               lang_opts +
+                               "]{babel}";
+       return tmp;
 }



This seems wrong. Shouldn't it be specialised for Jurabib?
Index: src/frontends/controllers/biblio.C
                switch (styles[i]) {
                case CITE:
+                       str = author;
+                       break;
+
                case CITET:


Doesn't look too clever calling the variable "natbib" any more...
Index: src/frontends/qt2/QCitation.C
-       bool const natbib = controller().usingNatbib();
+       bool const natbib = (controller().usingNatbib()
+                || controller().usingJurabib());



Wouldn't a combobox [plain | natbib | jurabib] be more elegant here?
Index: src/frontends/qt2/QDocument.C
-       dialog_->biblioModule->natbibCB->setChecked(
+       dialog_->biblioModule->citeNatbibRB->setChecked(
+               !params.use_natbib && !params.use_jurabib);
+       dialog_->biblioModule->citeNatbibRB->setChecked(
                params.use_natbib);
        dialog_->biblioModule->citeStyleCO->setCurrentItem(
                params.use_numerical_citations ? 1 : 0);
+       dialog_->biblioModule->citeJurabibRB->setChecked(
+               params.use_jurabib);