Andre Poenitz wrote:

> On Wed, Apr 07, 2004 at 10:52:38AM +0200, Alfredo Braunstein wrote:
>> Comments?
> 
> With exception of the unusual indentation in
> 
> +       /// draw a line from point to point
> +       Painter & line(int, int, int, int, LColor_color,
> +                      line_style = line_solid, line_width = line_thin)
> +               {
> +                       return *this;
> +               }
> 
> it looks really good.

Cool, I'll commit tonight then.

> Btw, is there any place in the code where the return value of these
> function is actually used?

Dunno. It would seem that the idea was to have 

painter.line(x,y).square(z,w,a,b) etc

or something, but it seems a bit silly anyways.

> Well, even if there were a few, I'd use
> 
>        void line(int, int, int, int, LColor_color,
>                     line_style = line_solid, line_width = line_thin)
>        {}

Agreed. That would look very nice in the patch linecount perspective ;-)

Alfredo


Reply via email to