John Spray <[EMAIL PROTECTED]> writes:
>> | --- src/frontends/gtk/GPainter.h 2004/05/19 15:11:32 1.9
>> | +++ src/frontends/gtk/GPainter.h 2004/09/26 14:57:18
>> | @@ -15,6 +15,7 @@
>> | #include "frontends/Painter.h"
>> |
>> | #include <X11/Xft/Xft.h>
>> | +#include <gtkmm.h>
>>
>> Were there errors because this missing?
| Now that I try again, no. That's fine as long as GPainter is included
| after <gtkmm.h> has already been included.
I have a patch ready that fixes up the include order. This time I even
have it tested :-)
| However, the changes to the #includes *are* necessary in GXpmBtnTbl.h.
| Because not all of these headers that use gtk actually include it
| themselves, the "#include <gtkmm.h>" should always come as early as
| possible in the including file.
No. All files should be compilable separately. Even header files.
>
>> Seems from gtk doc that Combo is deprecated, should we change that as
>> well?
| Combo is deprecated in favour of ComboBox, but since a combobox isn't
| the right widget (we're not allowing text input, just selecting from a
| list), I don't want to waste time on migrating to it. This widget
| should ultimately be an OptionMenu, I think.
Not ComboDropDown?
>
>> | + toolbar.insert(*toolitem,-1);
>>
>> and why is "insert" beeing used? Why not just "append" or "prepend"?
| Those functions are marked as deprecated in the gtk+ docs (I'm referring
| to a mixture of the gtk+ docs and the gtkmm docs).
But... we are not using gtk+, we are using gtkmm...
I really hope that Gtk guys will stay with the append/prepend
interface, it is a lot better than using magical values (0,-1).
(and the gtk+ guys probably need a kick in the b...)
| Sorry about the somewhat numerous random space/newline issues, cvs
| update went on a bit of an unexpected rampage and not everything got put
| back quite right.
| Sorry about the somewhat numerous random space/newline issues, cvs
| update went on a bit of an unexpected rampage and not everything got put
| back quite right.
What kind of double talk is this?
(I think I fixed it up before committing.)
--
Lgb
