Am Freitag, 11. Februar 2005 22:19 schrieb Andre Poenitz:
> Please add a FIXME line.

Like the attached? I must admit that I don't really know what the FIXME 
should say, because some lines later it is clearly documented that this 
part of the code is broken:


#ifdef WITH_WARNINGS
#warning replace this code by something that works
// This code does not work because we have currently no way to move up
// in the hierarchy of insets (JMarc 16/08/2004)
#endif
#if 0
/* I think this code is supposed to be useful when one has a caption
 * in a minipage in a figure inset. We need to go up to be able to see
 * that the caption should use "Figure" as label
 */


Georg
diff -p -r -U 3 -X excl.tmp lyx-1.4-clean/src/text2.C lyx-1.4-cvs/src/text2.C
--- lyx-1.4-clean/src/text2.C	2005-02-10 21:17:24.000000000 +0100
+++ lyx-1.4-cvs/src/text2.C	2005-02-12 17:37:32.000000000 +0100
@@ -791,6 +793,7 @@ void LyXText::setCounter(Buffer const & 
 			bool isOK = false;
 			while (tmppit != end) {
 				in = pars_[tmppit].inInset();
+				// FIXME: in should be always valid.
 				if (in &&
 				    (in->lyxCode() == InsetBase::FLOAT_CODE ||
 				     in->lyxCode() == InsetBase::WRAP_CODE)) {

Reply via email to