>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> Fine. Does this look Ok? 

+
+       dnl Preprocessor flags
+       echo ${host} | grep 'mingw' >/dev/null && {
+               QT_CPPFLAGS="-DQT_DLL -DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR"
+       } || {
+               QT_CPPFLAGS="-DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR"
+       }
+       AC_SUBST(QT_CPPFLAGS)

I'd really prefer something like

dnl Preprocessor flags
case ${host} in
 *mingw*) QT_CPPFLAGS="-DQT_DLL -DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR";;
       *) QT_CPPFLAGS="-DQT_CLEAN_NAMESPACE -DQT_GENUINE_STR";;
esac
AC_SUBST(QT_CPPFLAGS)

This avoids a call to grep/echo, and is in line with what we do
everywhere else.

JMarc

Reply via email to