Jean-Marc Lasgouttes wrote:
> It is definitely the best solution. About the tests, what about using
> #if defined(Q_WS_X11) && QT_VERSION >= 0x030200

OK. I was careful because I didn't know how these two tests can be mixed. 
Thanks.

> You could also define a USE_INPUT_METHODS in QContentPane.h
> #if defined(Q_WS_X11) && QT_VERSION >= 0x030200
> #define USE_INPUT_METHODS 1
> #endif
> and use this later. The advantage is to make the meaning of the test
> clear.

Yes, this is semantically very clear. I'll use this and commit.

Jürgen 

Reply via email to