>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:

Angus> Just for completeness, here are patches that I believe will
Angus> allow tex2lyx to run successfully on Win95 and Win98 and will
Angus> allow both LyX 1.3.x and LyX 1.4.x to be used as a conversion
Angus> filter on such machines. (It's likely that Qt/WinFree will die
Angus> a horrible death though...)

It looks much better. Two remarks (that you can freely ignore if you
want):

1/ it is not necessary to expose GetLongPath in os_win32.h, since this
is internal to os_win32.C.

1a/ the first comment in this class definition is bogus:
+/** This class provides a portable wrapper to SHGetFolderPathA that can be

2/ I am not sure why you need the global win32_folder_path pointer. Is
it some kind of optimization? In any case, this could leave in
os_win32 and be initialized in os_win32::init(). This would allow you
to expose a simple function in os_win32.h (since the implementation
details are not very interesting from Package point of view).

Nice work.

JMarc

Reply via email to