Martin Vermeer wrote: > On Fri, 2006-02-03 at 09:29 +0100, Georg Baum wrote: >> - The attached 1.3 file is read correctly with and without your patch. >> Your or Helge found a problem with 1.3 compatibility, but I can't find it >> anymore. Could you please give an example again? > > A file with Norsk as default/buffer language, text set to Swedish, an > inset inserted into the text, text inside the inset set back to Norsk. > > In 1.3 the text inside the inset will be Norsk. In 1.4 unpatched I don't > remember; with my patch, Swedish (Norsk is interpreted as > "inherit_language")
Unpatched 1.4 does the same as 1.3 (I tested with the updated attached file, look at the center tabular cell), so your patch creates the file format change that I thought was already in unpatched 1.4 :-( > I did. Quotes etc. indeed do not get underlined with my patch. So it is > wrong. A solution might be to give paintForeignMark an additional > "descent" parameter and use that to put the line at the right level. Yes, but how do we determine the value of this parameter? We basically need a list of insets that need the blue line at the bottom -> huge switch or virtual method, or do you see any other possibility? >> I would suggest to only apply the obvious changes, and leave the fixes >> for correctly propagating language changes to insets out. Especially the >> meaning of noFontChange() should not be changed, since it is wrong >> already. > > OK in principle... but could you list in detail which pieces of the > patch you want included and which excluded? I'll create a patch this evening. > BTW being both > bug-compatible with 1.3 and reasonably well behaved may be undoable. Yes, but IMO we should not fix 1.3 bugs now. I am sure that it is possible to be at least as well behaved as 1.3 >> The problem with inherited language in insets should IMO be fixed by >> setting an explicit language upon reading a file and creating new stuff. >> Then the language is never inherited, and the underlining will >> automatically be correct. > > I looked at that... didn't get anywhere. Yes, in principle. This is probably for later, since it might indeed require a file format change. Georg
2115-221.lyx
Description: application/lyx
