On Fri, Feb 03, 2006 at 10:19:45PM +0100, Georg Baum wrote: > Am Freitag, 3. Februar 2006 10:34 schrieb Martin Vermeer: > > OK in principle... but could you list in detail which pieces of the > > patch you want included and which excluded? > > Here is the patch. It is IMO safe for 1.4.0, and it fixes all language > related problems I could think of except changing language inside insets > as part of a selection (the stuff related to bug 1973). > Note that my replacement for LyXText::bufferFont() still uses > LyXText::bv() in some places, so it is only marginal better.
On the whole, OK; but I suggest you put applyOuterFont under your pillow tonight and return to it tomorrow... I am guilty of this method, but I strongly feel now that it does things the wrong way around. I would be highly surprised if this replicated 1.3 behaviour anywhere near faithfully. E.g., try this: set a font attribute -- emphasise -- externally, in the text containing the inset; then, try to revert the attribute for the text inside. - Martin
pgpUdkrtJqyEp.pgp
Description: PGP signature
