Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Abdelrazak Younes wrote:
Hello,
I would like to put this in but I touched a tiny bit the other
frontends. Any objection?
Abdelrazak> As there is none, I am going to commit.
Since you are complaining:
Am I complaining?
what do you gain by doing that? Speed?
A tiny bit.
Simplicity?
A great bit :-)
And furthermore it get rid of a bug that I noticed sometimes with cursor
drawing. Namely that the trace of the former cursor remains after you
move it.
If it is really useful, we should do that for all
frontends.
It is not that useful but it is cleaner code wise. Since the beginning
of my qt4 port I wondered why we needed to save the "no cursor" region
and restore it. With this patch I finally got rid of it by drawing the
cursor after the work-area and only if it is needed.
Actually, I have never been sure of what LyXScreen does.
IMHO it is useless. I really don't see the advantage of distinguishing
the Screen from the Work-area. AFAIS, except for the cursor and expose()
handling, the only use of the LyXScreen is to pass workArea(). So there
is a lot of workArea() call everywhere in the code that is useless.
As my patch proves it, the expose() and cursor handling can be delegated
directly to the workArea.
Abdel.
