Georg Baum wrote:
Abdelrazak Younes wrote:

AFAIS, wa_ptr is equivalent to "this" and is not used anywhere else.

It is used in lyxX11EventFilter

Could be replaced by "this".

and checkAppleEventForMissingParams (only in
OS X).

and handleOpenDocuments, I _know_. I plan to move these function to "lyx_gui.C" or "WorkAreaFactory.C".

Figuring out the reason why it is needed there is left as an
exercise for the reader.

Well, my point is that it is not used anywhere else but in "QWorkarea.C". In there, maintaining a global variable pointer is useless as there is anyway only one QWorkArea instance in LyX and it is created in WorkAreaFactory.C. Ultimately, I plan to remove this global variable.

So, can I remove it?

No. But it could be put in an OS X ifdef. Looks like I become the "No"-sayer
here.

I am not going blindly here and I think I know the code quite well so in this case I need a bit more argument than "No" ;-)

Abdel.

Reply via email to