[EMAIL PROTECTED] wrote:

Author: schmitt
Date: Wed Jun  7 22:46:39 2006
New Revision: 14037

Log:
revise comments

Modified:
   lyx-devel/branches/personal/gerz/change-tracking/src/insets/insettext.C

The result of a lonely evening...

Michael
Index: insets/insettext.C
===================================================================
--- insets/insettext.C	(Revision 14035)
+++ insets/insettext.C	(Arbeitskopie)
@@ -372,7 +372,8 @@
 	for (; it != end; ++it)
 		for (int i = 0; i < it->size(); ++i)
 			if (it->isNewline(i))
-				it->erase(i, false); // do not track change
+				it->erase(i, false); // do not track change, because the user
+				                     // is not allowed to revert/reject it
 }
 
 
@@ -406,11 +407,11 @@
 
 void InsetText::appendParagraphs(Buffer * buffer, ParagraphList & plist)
 {
-#ifdef WITH_WARNINGS
-#warning FIXME Check if Changes stuff needs changing here. (Lgb)
-// And it probably does. You have to take a look at this John. (Lgb)
-#warning John, have a look here. (Lgb)
-#endif
+	// There is little we can do here to keep track of changes
+	// As of 2006/06/07, appendParagraphs is used exclusively by
+	// LyXTabular::setMultiColumn. In this context, the paragraph break
+	// is lost irreversibly and the appended text doesn't really change
+
 	ParagraphList & pl = paragraphs();
 
 	ParagraphList::iterator pit = plist.begin();
@@ -420,7 +421,7 @@
 		       std::distance(pl.begin(), ins) - 1);
 
 	for_each(pit, plist.end(),
-		 bind(&ParagraphList::push_back, ref(pl), _1));
+		bind(&ParagraphList::push_back, ref(pl), _1));
 }
 
 

Reply via email to