On Mon, Jun 12, 2006 at 08:54:49PM +0200, Peter Kümmel wrote:
> resize(width, height);
>
> + if(isMax)
> + this->setWindowState(Qt::WindowMaximized);
Spacing. Also, the this-> should not be needed outside template code.
So:
if (isMax)
setWindowState(Qt::WindowMaximized);
> + LyX::ref().session().saveSessionInfo("WindowWidth",
> convert<string>(this->normalGeometry().width()));
> + LyX::ref().session().saveSessionInfo("WindowHeight",
> convert<string>(this->normalGeometry().height()));
> + LyX::ref().session().saveSessionInfo("WindowIsMaximized",
> (this->isMaximized() ? "yes" : "no"));
> if (lyxrc.geometry_xysaved) {
> - LyX::ref().session().saveSessionInfo("WindowPosX",
> convert<string>(x()));
> - LyX::ref().session().saveSessionInfo("WindowPosY",
> convert<string>(y()));
> + LyX::ref().session().saveSessionInfo("WindowPosX",
> convert<string>(this->normalGeometry().x()));
> + LyX::ref().session().saveSessionInfo("WindowPosY",
> convert<string>(this->normalGeometry().y()));
A reference to LyX::ref().session() could be used to mak the code more
compact.
Again, unless this is templated code, 'this->' is not needed.
> /// create a main window of the given dimensions
> - QtView(unsigned int w, unsigned int h);
> + QtView(unsigned int w, unsigned int h, bool isMAx);
isM_a_x
Looks good otherwise.
Andre'
