On Thu, Jun 15, 2006 at 12:39:32PM +0200, Abdelrazak Younes wrote:
> Minus potential compilation problems with gtk and/or xforms I think I am
> ready to merge my branch with trunk. Please find attached the complete
> patch. I will wait for some green lights before applying.
Good boy.
> void exec(int & argc, char * argv[])
> {
> + /*
> + FIXME : Abdel 29/05/2006 ([EMAIL PROTECTED])
> + reorganize this code. In particular make sure that this
> + advise from Qt documentation is respected:
> +
> + Since the QApplication object does so much initialization, it
> + must be created before any other objects related to the user
> + interface are created.
> +
> + Right now this is not the case. For example, the call to
> + "FontLoader::initFontPath()" below is doned before the QApplication
s/doned/done/
> + creation. Moreover, I suspect that a number of global variables
> + contains Qt object that are initialized before the passage through
> + parse_init(). This might also explain the message displayed by Qt
> + that caused the hanging:
> +
> + QObject::killTimer: timers cannot be stopped from another thread
> + */
[Btw I think this is true. th QApplication should be created as eaerly
as possible]
> Index: src/insets/insettabular.h
> ===================================================================
> --- src/insets/insettabular.h (revision 14120)
> +++ src/insets/insettabular.h (working copy)
> @@ -37,14 +37,19 @@
>
> class FuncStatus;
> class LyXLex;
> -class Painter;
> class BufferView;
>
> +namespace lyx {
> +namespace frontend {
> +class Painter;
> +}
> +}
> [...]
> ///
> - void drawCellLines(Painter &, int x, int y, row_type row,
> + void drawCellLines(lyx::frontend::Painter &, int x, int y, row_type row,
> idx_type cell, bool erased) const;
[Well, somehow I still think we should just dump everything in a big
'lyx' namespace and use 'using namespace lyx' in the .C files. The
nested namespaces are just line noise... But I guess that's not the time
and place to discuss that.]
Andre'
