Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | This patch makes it compile (and probably breaks qt), but xforms
| > fails
| > | brutally upon start up.
| > This patch even makes it run, albeit with a grabled screen. The gui
| > operations (adding objects and such) are done in the wrong order.
|
| The next patch solves this?
No, this is entering the murky waters of our xforms layout engine.
| > // Make sure the buttons are disabled if needed.
| > - updateToolbars();
| > + //updateToolbars();
|
| Are you sure about this change? I haven't touched at the toolbars and
| menubars API yet.
There are no such function anymore so I cannot really call it...
Why is that? I did not touch updateToolbars(), only
BufferView::updateSrollbar()...
(So currently xforms scrollbar is not working, but the whole screen is
garbled so hard to do anything anyway...)
I see.
| > Index: src/frontends/xforms/GuiImplementation.C
| > ===================================================================
| > --- src/frontends/xforms/GuiImplementation.C (revision 0)
| > +++ src/frontends/xforms/GuiImplementation.C (revision 0)
|
| FYI, the reason I implemented everything in the header with the
| typedef trick is that it enables to have a common part for qt3, gtk
| and xforms. This way, once the qt3 was ready, I just had to copy and
| paste the common part to gtk and xforms.
| The rest looks good to me.
The GuiI stuff with the typedefs looks really dirty. It just brought
me confusion and errors.
If you want to cherry-pick stuff from the patch and apply that to the
branch right away please do.
No, please commit your patch. This was just for your information. If
these frontend are going to be cleaned up to support multiple views and
work areas the .h/.C split should be done of course and I am grateful
that you did it.
Abdel.
