Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

Abdelrazak> Hello, I don't think there would be any objection to this
Abdelrazak> patch but I'll wait till the end of the day before
Abdelrazak> committing. After this patch the BufferView.h and
Abdelrazak> BufferView_pimpl.h headers are pretty similar. So, unless
Abdelrazak> there is a strong objection I will put the cursor handling
Abdelrazak> out of the pimpl and then merge the two classes when I get
Abdelrazak> some free time.

I have no objection.

I will commit now then.

Merging the bufferview pimpl makes sense, if we
managed to get rid of the extra headers.

"BufferView_pimpl.h" has those four additional headers:

#include "cursor.h"
#include "errorlist.h"
#include "frontends/Timeout.h"
#include <boost/signals/trackable.hpp>

If we manage to transfer the cursor handling to frontends/GuiCursor, only those two will remain:

#include "errorlist.h"
#include <boost/signals/trackable.hpp>


Abdel.

Reply via email to