Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
| > [EMAIL PROTECTED] (Lars Gullik Bjønnes) writes:
| > | Like so.
| > I see that I missed quite a few emit's.
|
| What? You commit a patch without checking that it compiles?
But I did... unfortunately our build system does not rebuild things
when '-D' options is added to the compiler.... if these had been put
into a config.h file then a rebuild would have happened.
| > I'll fix that promptly.
|
| You never question whether yours changes are good or not, are you?
| I
| am not saying that this change is bad, FWIW I didn't know that the
| emit keyword was useless compiler wise, but it is useful to indicate
| that this function you are calling is a Qt signal. Without it, a
| casual developer will probably be mis leaded by the fact these methods
| do not have an implementation, I know I will. So some comments are in
| order.
I'll see what I can do...
(See... I am actually prepared to go the extra mile to please you)
--
Lgb
