Peter Kümmel <[EMAIL PROTECTED]> writes:

| Lars Gullik Bjønnes wrote:
| > I belive this one is safe. (I'll commit after work tomorrow(today))
| > Index: src/text2.C
| > ===================================================================
| > --- src/text2.C     (revision 14329)
| > +++ src/text2.C     (working copy)
| > @@ -212,7 +212,7 @@
| >                     break;
| >             }
| >     // Realize against environment font information
| > -   if (pit < pars_.size())
| > +   if (pit < pit_type(pars_.size()))
| >             font.realize(outerFont(pit, pars_));
| >  
| >     // Realize with the fonts of lesser depth.
| 
| Isn't it better to fix pit_type?

If you thimk that is easy...


 | type.h:
| 
|       /// a type for paragraph offsets
|       // FIXME: should be unsigned as well.
|       // however, simply changing it breaks a downward loop somewhere...
|       typedef ptrdiff_t  pit_type;
| 
| When you remove the warning we maybe will forget about it,
| so I would not remove this warning.

Add a 'FIXME' and still get rid of the warning is the option IMHO.
 
-- 
        Lgb

Reply via email to