>>>>> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes:
Juergen> Juergen Spitzmueller wrote:
>> Attached is a patch that fixes the crash for me, but I'm not sure
>> it produces the behaviour we want (delete the empty paragraph,
>> which is inconsistent to what LFUN_LEFTSEL does in this case).
Juergen> attached is the proper fix, IMO. selHandle has to be used,
Juergen> because it makes sure that the selection is properly set,
Juergen> which was not the case without that method. That's why DEPM
Juergen> was erroneously triggered.
I tried to do something like that, but ran out of time. The following
code is a bit weird, though:
case LFUN_ENDBUFSEL:
if (cur.depth() == 1) {
- if (!cur.selection())
- cur.resetAnchor();
+ cur.selHandle(cmd.action == LFUN_ENDBUFSEL);
The test is bogus, you should pass true to selHandle, or merge
LFUN_ENDBUFSEL and LFUN_ENDBUF.
Juergen> This patch also fixes bug 2119 (Selection of text via
Juergen> keyboard sometimes fails) and bug 2259 (screen-up/down-select
Juergen> do not work).
Juergen> Too late for 1.4.2?
Not necessarily, it is kind of obvious. This needs testing.
JMarc
