Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| OK, here is my last patch before holidays (hopefully).
|
| This one continue the drastic diet operated on BufferView. It removes
| all boost signal from BufferView::pimpl and put them in LyXView.
| LyXView already inherits from boost::signals::trackable so this is not
| a big deal. If you look closely at the signal connections, it all
| makes sense IMO.
|
| With this change, the only difference between BufferView.h and
| BufferView_pimpl.h is "cursor.h" so I think it is time to merge at
| last the two classes.
|
| Comments? Objection?
Yes. I belive you have moved a bit too much. In particular the
errorList itself. That is not a frontend thing really it is a
bufferview thing.
| Log:
|
| BufferView:
| * showErrorList(), getErrorList(): transfered to LyXView.
So getErrorList should stay.
| BufferView::pimpl
| * addError(), showReadonly(), connectBuffer(), disconnectBuffer():
| transfered to LyXView.
addError should stay.
Other than that I think I agree with the patch.
--
Lgb
