I'm back from two weeks in Sveti Constantine, Bulgary (very nice btw) and I'm trying to catch up... Since I'm now at post 200 out of 900 I'd like to take a break and inject a question.

Please bear in mind that I'm not involved in processing of patches, so the questions might be totally off...

When comitting a patch that has been discussed on the list, would it make sense to let the *comitted* patch contain link or reference to the discussion?

Or is it better to require having explanations as comments directly in the code? Or part of the SVN log?

If the explanation is in the log, can you edit the explanation if it's not clear or incorrect? In my experience documenting your code is more work than writing it, it's especially difficult to get 100% correct.

I was merely thinking that if the patch contains a log message, I can see how you could "review" the log message in advance of comitting it.

cheers
/Christian

PS. I'm glad Abdel didn't retire and I'm holding my breath nothing bad has happened in the next 600 posts...

--
Christian Ridderström, +46-8-768 39 44               http://www.md.kth.se/~chr

Reply via email to