Abdelrazak Younes wrote:
OK, now I understand the problem, sorry for my autism ;-). Then the fix is even simpler for this particular dialog: just transfer the code in update_contents() to buil_dialog(). In any case, the error list will be automatically updated if a new error list is generated. Or am I missing something again?

The patch was wrong (I moved the code to QErrorList::select() instead of build_dialog()). Attached a patch that seems to be working (again for win-msvc/qt4).

Abdel.

Index: QErrorList.C
===================================================================
--- QErrorList.C        (revision 14623)
+++ QErrorList.C        (working copy)
@@ -35,19 +35,7 @@
 {
        dialog_.reset(new QErrorListDialog(this));
        bcview().setCancel(dialog_->closePB);
-}
 
-
-void QErrorList::select(QListWidgetItem * wi)
-{
-       int const item = dialog_->errorsLW->row(wi);
-       controller().goTo(item);
-       
dialog_->descriptionTB->setPlainText(toqstr(controller().errorList()[item].description));
-}
-
-
-void QErrorList::update_contents()
-{
        setTitle(controller().name());
        dialog_->errorsLW->clear();
        dialog_->descriptionTB->setPlainText(QString());
@@ -62,5 +50,18 @@
        select(dialog_->errorsLW->item(0));
 }
 
+
+void QErrorList::select(QListWidgetItem * wi)
+{
+       int const item = dialog_->errorsLW->row(wi);
+       controller().goTo(item);
+       
dialog_->descriptionTB->setPlainText(toqstr(controller().errorList()[item].description));
+}
+
+
+void QErrorList::update_contents()
+{
+}
+
 } // namespace frontend
 } // namespace lyx

Reply via email to