Angus Leeming wrote:
Abdelrazak Younes wrote:
Hello,
The subject says it all. This patch is obviously the right thing to do
so I will commit soon.
Is it really the right thing to do? Imagine that you have multiple
bufferviews on a buffer. If you perform some action from one bufferview,
do you really want the message to be displayed in all of them? (If we
had multiple windows then the message would be displayed in the
minibuffer at the bottom of each window.)
Hum, you have a point but I still think that this is the right thing to
do. If the Buffer is changed then it should say so regardless to wo is
listening (or watching). _But_ an additional filtering should be done
somewhere that will let the connected LyXView to decide whether to
display this message on screen. I guess autosave related messages or
reconfigure messages should be shown on all LyXView but inset insertion
in a non currently visible part of the Buffer should not be displayed
for example.
I think that the code is right as it is.
If need be we can create a BufferView::message() signal in the future
that will allow to differentiate between different kind of messages. But
this kind of feature should really be asynchronous so emitting a signal
is the right thing to do.
I really want to free BufferView from the knowledge of LyXView.
Abdel.
