Angus Leeming wrote:
Edwin Leuven wrote:
the attached patch fp.diff
* implements the float widget as a .ui file
* renames from floatplacement.[Ch] -> FloatPlacement.[Ch]
compare.diff shows the differences between the two files
If you'd used svn rename I think this diff would have come for free,
wouldn't it?
comments welcome
Given that FloatPlacementUi derives from QWidget:
+ <class>FloatPlacementUi</class>
+ <widget class="QWidget" name="FloatPlacementUi" >
I don't think FloatPlacement needs to derive directly from QWidget:
-class FloatPlacement : public QWidget {
+class FloatPlacement : public QWidget, public Ui::FloatPlacementUi {
Agreed.
Otherwise looks good except that you took the path of minimal effort ;-)
No automatic slots, etc...
Thanks,
Abdel.
