Georg Baum wrote:
Am Samstag, 2. September 2006 11:05 schrieb Abdelrazak Younes:
I have a lot of warning following the patch using MSVC. Should we fix
them? I guess most of them will be fixed once the code is ported to
char_type and docstring. I list them here for reference:
..\..\..\trunk\src\insets\insetcollapsable.C(258) : warning C4244:
'argument' : conversion from 'Paragraph::value_type' to 'char', possible
loss of data
That one will be fixed with one of my next patches, but I would be
surprised if it was caused by my last commit.
Dunno, haven't checked really. I was giving you the full output, sorry.
..\..\..\trunk\src\graphics\PreviewImage.C(59) : warning C4355: 'this' :
used in base member initializer list
That one is bogus.
Well, I think it is good practice to avoid that but yes it not harmful.
this looks to me as if you include qt_helpers.obj twice in the link
command. Maybe you project file is damaged. Can you please check that?
Yes, sorry, this is a CMake build that use the glob approach and I had a
"Copy of qt_helpers.C" file, just ignore this BS.
..\..\..\..\trunk\src\frontends\controllers\ControlSpellchecker.C(165) :
warning C4244: 'argument' : conversion from 'const
Paragraph::value_type' to 'char', possible loss of data
This one is fixed by the attached patch.
Good, I was about to look at this :-)
..\..\..\..\trunk\src\frontends\controllers\ControlSpellchecker.C(166) :
warning C4244: 'argument' : conversion from 'const
Paragraph::value_type' to 'unsigned char', possible loss of data
This one is not so easy (can digits be something else than ASCII 0-9?)
What is Paragraph::value_type? I guess it should be a char_type, we have
to verify that Aspell will understand that.
fixed. Here I got bored and did not look at the others, since they do
probably not result from my patch. Please have a look yourself if you find
some time.
Good work Georg ;-)
Abdel.
