Lars Gullik Bjønnes wrote:
Abdelrazak Younes <[EMAIL PROTECTED]> writes:
| Georg Baum wrote:
| > Am Sonntag, 3. September 2006 12:28 schrieb Abdelrazak Younes:
| >> Georg Baum wrote:
| >>> Am Sonntag, 3. September 2006 12:11 schrieb Abdelrazak Younes:
| >>>> This patch fixes the isDigit() MSVC warning in ControlSpellchecker.C.
| >>> If that is really the correct isDigit() check for unciode
| >> My understanding is that ascii is a subset of ucs4 so it must work as is.
| > That is true, but the question is rather: For what purpose is
| > isDigits used? Shall it be true for digits in other scripts, or are
| > ASCII digits enough? I don't know.
|
| For one, isDigit() is used in LyXText::insertChar() and it works with
| my change.
| isLineSeparatorChar() is also used there and it works as expected.
Yes, but it is not unicode correct.
We need to lookup the unicode tables to discover if a codepoint is a
number or not.
Because there might be other digits than 0,...9? Or is it that those
digit might also be encoded in other unicode chars than the ascii subset?
Abdel.
